Skip to content

spec-sync(v2): document extract options.grounding (unwired, use extra_body) - #167

Merged
tian-lan-landing merged 2 commits into
mainfrom
spec-sync/v2
Sep 16, 2026
Merged

tian-lan-landing merged 2 commits into
mainfrom
spec-sync/v2

Conversation

@yzld2002

@yzld2002 yzld2002 commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Automated V2 spec-sync PR (client.v2).

  • Commit 1 (mechanical): normalized V2 spec snapshot + regenerated reference models.
  • Commit 2 (AI, only if the spec diff needs SDK changes): client.v2 resources/methods/tests/docs wired from the diff, added after this PR opened. Workflow-only drift is excluded and an AI no-op is skipped, so some drifts produce a mechanical-only PR with no second commit.

Gates (surface-lock, V2 contract tests, lint/test/typecheck) must pass. When present, the AI commit is a draft a human finishes (the V2 ergonomic layer — unified Job, dual-host, schema coercion — is not in the spec). Human review required before merge.

What changed

AI-generated from the PR diff — verify against the actual changes.

This PR re-adds the options.grounding field to the extract spec but keeps it unexposed as SDK surface, reachable only via extra_body.

Changes:

  • Spec now documents options.grounding (Preview boolean, default true) on the extract request schema across sync/async and JSON/form-data routes.
  • extract continues to expose only strict as a top-level keyword shorthand; grounding remains unwired pending a joint decision with ade-typescript.
  • Docs updated to show reaching grounding via extra_body={"options": {"grounding": ..., "strict": ...}}, noting the merge is shallow at the top level.
  • New tests pin that the SDK's own options payload carries only strict, and that grounding is reachable solely through extra_body.

Copilot AI balanced review requested due to automatic review settings September 15, 2026 17:02
@yzld2002
yzld2002 deployed to spec-sync-contract September 15, 2026 17:02 — with GitHub Actions Active
@yzld2002 yzld2002 changed the title spec-sync: track V2 spec drift spec-sync(v2): document extract options.grounding (unwired, use extra_body) Sep 15, 2026
@yzld2002
yzld2002 deployed to spec-sync-contract September 15, 2026 17:07 — with GitHub Actions Active

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@tian-lan-landing
tian-lan-landing merged commit 9b6d7f3 into main Sep 16, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
spec-sync-contract — 0df9b7e3 Deployed Sep 15, 2026 by yzld2002 via contract-tests #182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants